Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picard: MarkDuplicates: account for missing trailing 0 #2094

Merged
merged 3 commits into from Oct 3, 2023
Merged

Conversation

vladsavelyev
Copy link
Member

Fixes #2063

Some MarkDuplicates outputs have a missing 0 value for the last column for libraries with all zeroes, so need to parse an empty string properly as 0.0.

@vladsavelyev vladsavelyev added the bug: core Bug in the main MultiQC code label Oct 1, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.17 milestone Oct 1, 2023
@vladsavelyev
Copy link
Member Author

@multiqc-bot changelog

@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Oct 1, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks cleaner logic now. Prefer having it at the end like that. Thanks!

@ewels ewels merged commit ac93dc3 into master Oct 3, 2023
6 checks passed
@ewels ewels deleted the fix-picard branch October 3, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. bug: core Bug in the main MultiQC code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picard MarkDuplicates 1 out many thousands of runs broke
3 participants