Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger changelog entry addition on PR creation, in addition to an explicit comment to multiqc-bot #2102

Merged
merged 4 commits into from Oct 8, 2023

Conversation

vladsavelyev
Copy link
Member

Helpful for quick and simple pull requests. Additional "@multiqc-bot changelog" comments will replace an exiting comment anyway if needed.

@vladsavelyev vladsavelyev added awaits-review Awaiting final review and merge. core: infrastructure Something to do with the MultiQC infra labels Oct 3, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.17 milestone Oct 3, 2023
@vladsavelyev
Copy link
Member Author

@multiqc-bot changelog

@ewels
Copy link
Member

ewels commented Oct 4, 2023

What about PRs where we don't want a changelog entry?

Need a command for @multiqc-bot remove changelog 😆

@vladsavelyev
Copy link
Member Author

Lol I haven't thought about it. Need @multiqc-bot remove changelog and also the previous approach with ... (chore) 😬

@vladsavelyev vladsavelyev removed the awaits-review Awaiting final review and merge. label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🚀 Deployed on https://mqc-pr-2102--multiqc.netlify.app

@vladsavelyev
Copy link
Member Author

Instead, went with an optional marker [skip changelog] in the PR title. It makes the CI skip adding the entry, and also also works to remove an existing changelog entry if added later.

@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Oct 6, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ewels ewels merged commit bb1cb1b into master Oct 8, 2023
7 checks passed
@ewels ewels deleted the changelog-on-pr-creation branch October 8, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. core: infrastructure Something to do with the MultiQC infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants