Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellranger: Count submodule updated to parse Antibody Capture summary #2118

Merged
merged 14 commits into from Oct 17, 2023
Merged

Cellranger: Count submodule updated to parse Antibody Capture summary #2118

merged 14 commits into from Oct 17, 2023

Conversation

achakkas
Copy link
Contributor

@achakkas achakkas commented Oct 13, 2023 •
edited by vladsavelyev

Updated the existing cellranger count module to show additional data from antibody tabs when present in the web_summary.html.

  • Added Antibody - Summary stats for reports with antibody tabs
  • Added Antibody - Counts Distribution Bargraph for reports with antibody tabs

vladsavelyev
vladsavelyev reviewed Oct 15, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vladsavelyev vladsavelyev self-requested a review October 15, 2023 17:41
@vladsavelyev vladsavelyev added this to the MultiQC v1.17 milestone Oct 15, 2023
@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Oct 15, 2023
vladsavelyev
vladsavelyev approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@vladsavelyev vladsavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution!

@vladsavelyev vladsavelyev changed the title Cellranger count module updated to parse Gene Expression + Antibody Capture summary files Cellranger: Count submodule updated to parse Antibody Capture summary Oct 15, 2023
@vladsavelyev
Copy link
Member

@multiqc-bot changelog

ewels
ewels approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, would be nice to group together the Antibody report sections though, underneath the Count sections.

@vladsavelyev vladsavelyev merged commit bc592ac into MultiQC:master Oct 17, 2023
7 checks passed
@chris-rands
Copy link

Thank you! Partially closes #1909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

@vladsavelyev vladsavelyev vladsavelyev approved these changes

Assignees
No one assigned
Labels
awaits-review Awaiting final review and merge.
Projects
None yet
Milestone
MultiQC v1.17: Logo and Python 3.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@achakkas @vladsavelyev @chris-rands @ewels @multiqc-bot