Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hicpro: fix parsing scientific notation in hicpro-ashic. Thanks @Just-Roma #2126

Merged
merged 3 commits into from Oct 16, 2023

Conversation

vladsavelyev
Copy link
Member

Fixes #1922

Thanks @Just-Roma for the fix.

@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Oct 16, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.17 milestone Oct 16, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@ewels ewels merged commit 21aded9 into master Oct 16, 2023
6 checks passed
@ewels ewels deleted the hicpro-fix-scientific-notation-parse branch October 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in nf-core/hic MultiQC: invalid literal for int()
3 participants