Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualimap: BamQC: fix for global-only stats #2207

Merged
merged 4 commits into from Dec 11, 2023
Merged

Qualimap: BamQC: fix for global-only stats #2207

merged 4 commits into from Dec 11, 2023

Conversation

vladsavelyev
Copy link
Member

Make sure that all columns are present when input is global-only (no Globals inside section with regions_size and regions_mapped_reads is available). Remove the broad try-except and be more granular in metric parsing.

Fixes #2199

@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Dec 1, 2023
@vladsavelyev vladsavelyev mentioned this pull request Dec 1, 2023
Closed
4 tasks
@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Dec 1, 2023
@ewels ewels merged commit 634e4e5 into master Dec 11, 2023
6 checks passed
@ewels ewels deleted the qualimap-missing-col branch December 11, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
awaits-review Awaiting final review and merge. bug: module Bug in a MultiQC module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qualimap module missing "percentage_aligned" after 1.16
3 participants
@vladsavelyev @ewels @multiqc-bot