Pagination support to list all tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @ewilde @canthefason |
ewilde
requested changes
Dec 10, 2018
Co-Authored-By: charleschengxu <charlesxu1995@gmail.com>
Co-Authored-By: charleschengxu <charlesxu1995@gmail.com>
Co-Authored-By: charleschengxu <charlesxu1995@gmail.com>
|
@charleschengxu 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
BucketNametoBucketKeyinListTestsInputto be consistent with Runscope API. Really, even many of the integration tests were doingBucketName: bucket.Key, which also warrents the correction.Add
Offsetfield toListTestsInputso pagination is possible. This is a field offcially supported by the Runscope API https://www.runscope.com/docs/api/tests#list.Correct the docstring on
ListTests()since it does NOT list all tests, and implement anotherListAllTests()function using pagination with test coverage.All tests passed locally.