adds method to read test metrics #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilde
requested changes
Jan 3, 2019
client.go
Outdated
| @@ -101,14 +102,14 @@ func NewClientAPI(apiURL string, accessToken string) ClientAPI { | |||
|
|
|||
| func (client *Client) createResource( | |||
| resource interface{}, resourceType string, resourceName string, endpoint string) (*response, error) { | |||
| DebugF(1, "creating %s %s", resourceType, resourceName) | |||
test.go
Outdated
| environmentUUID = "all" | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] reading %s %s", "metrics", test.ID) |
ewilde
approved these changes
Jan 3, 2019
ewilde
reviewed
Jan 4, 2019
| region = "all" | ||
| } | ||
| if timeframe == "" { | ||
| timeframe = "month" |
There was a problem hiding this comment.
@sam-io out of interest why do we default to month, api default is day?
There was a problem hiding this comment.
probably because that is the value that I needed for the project I was working on, the default should be day though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.