Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts reported when two development solutions contain an entity as a container only #79

Closed
ewingjm opened this issue May 28, 2021 · 0 comments · Fixed by #80
Closed
Labels
bug Something isn't working

Comments

@ewingjm
Copy link
Owner

ewingjm commented May 28, 2021

Description

When two development solutions contain the same entity as a container only (i.e. metadata not included), approving a solution merge for one of these development solutions will show a potential warning conflict for the other solution.

Steps to reproduce
Steps to reproduce the behaviour:

  1. Create two issues and progress them to an in progress status
  2. Add the same entity to both development solutions excluding metadata
  3. Create a solution merge for one of the issues
  4. Click the approve button
  5. Observe a conflict is reported

Expected behaviour
No conflict should be reported.

Additional context
The only possible conflict that can arise from this scenario would be if one of the solutions has made ribbon changes to the entity. Ribbon changes don't require entity metadata to be added in order to be included in the solution. Ribbon changes are made far more infrequently than changes to entity sub-components, however, so it is probably preferable to avoid lots of false positives in favour of a few false negatives (that should be picked up on the pull request anyway).

@ewingjm ewingjm added the bug Something isn't working label May 28, 2021
ewingjm pushed a commit that referenced this issue Jun 7, 2021
Resolves #79. Conflicts were detected when two development solutions contained the same entity as a container only. 

+semver: patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant