fix: manual retry needed if master instance paused #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-progress-error
ewingjm
deleted the
bugfix/large-development-solutions-import-in-progress-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #26, fixes #12. Solution merges would occasionally fail with a message stating that the solution cannot be imported because of another solution import in progress. This was due to the fact that it would attempt to import the solution again if the action exceeded the 2-minute timeout.
Approach
Refactoring of the merging flow to not automatically retry the solution import. Instead, we query for the import job whether the solution import action succeeded or timed out.
This pull request also contains some wider refactoring, moving the majority of the code to flow and moving the app registration details from plug-in step configuration to the Environment table.
BREAKING CHANGE: users that update to this version will need to re-enter their app registration details in their environment record(s) (previously within plug-in step secure configuration).
TODOs