Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merges that fail after 2 minutes continue to retry #60

Merged

Conversation

ewingjm
Copy link
Owner

@ewingjm ewingjm commented Feb 6, 2021

Purpose

Some merges retry for an hour despite the development solution import failing.

Approach

Checks for a value in the completedon field of the importjob rather than checking that the progress field is 100. when determining when to stop polling for updates on the import. Failures occur without the progress being updated to 100.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

@ewingjm ewingjm added the bug Something isn't working label Feb 6, 2021
@ewingjm ewingjm merged commit efd3457 into master Feb 6, 2021
@ewingjm ewingjm deleted the bugfix/solution-failures-after-2-minutes-continue-to-retry branch February 6, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development solution imports that fail after 2 minutes needlessly retry for an hour
1 participant