allow approver to complete manual merge activities #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #81. |
ewingjm
previously approved these changes
Jul 7, 2021
|
@ewingjm Thanks for reviewing. I think you need to manually trigger the checks? |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tdashworth would you mind adding this into the power-apps-bindings.yml? browserOptions:
driversPath: ChromeWebDriverShould fix the error you're getting on the pipeline. I was going to just bypass the policy and merge this as I know it doesn't impact the few tests that are there but I realised we'll just get the same error on the CI run and we won't get a release published. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
On our project, the user approving the Solution Merge will often also carry out the manual steps (documented in a Note). The problem is that only the creator of the Solution Merge Request can confirm these have been done via an Approval.
#81
Approach
Allows both creator and approver to complete the manual merge activities.
TODOs