Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for building layout header in admin area is duplicated in JS #5

Open
ewinslow opened this issue Apr 14, 2012 · 0 comments
Open

Comments

@ewinslow
Copy link
Owner

This is not maintainable as is. Furthermore, it's not even correct as is. The title menu cannot be generated correctly for ajax-loaded pages. Need to think more about how that would work. Forcing people to rely on the hook + passing all parameters to the menu explicitly seems like our best shot, but it's very different from how Elgg has done things so far (relying on global state). Maybe this is a good motivation to get away from that frowned-upon approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant