Small changes to make it work on Windows #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems great ! If I had an "AUTHORS" file, I'd suggest to add you it it, but I don't even have this... This project clearly needs a bit of work 😅 Note : if you just use # and the id of the issue without the word 'Issue', like this : #7 , then github auto-links to the issue, and pings the issue with a back-link to this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
1/ see #7: os.path doesn't use a valid separator on windows to construct an url.
Use of urllib instead.
2/ test_time was raising an AttributeError because of signal.SIGALRM, which doesn't exist on windows.
Small tweak to make the test not care if there is no SIGALRM.