Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Status 31354-RISCV_Add_XiangShan_Nanhu_microarchitecture-1 #1349

Closed
github-actions bot opened this issue Feb 27, 2024 · 4 comments
Closed

Patch Status 31354-RISCV_Add_XiangShan_Nanhu_microarchitecture-1 #1349

github-actions bot opened this issue Feb 27, 2024 · 4 comments
Labels
linter-failure Lint failed

Comments

@github-actions
Copy link

Precommit CI Run information

Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/8069611220

Patch information

Applied patches: 1 -> 1
Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=31354
Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240227085243.605255-1-jiawei@iscas.ac.cn/
Patch id: 86420

Build Targets

Some targets are built as multilibs. If a build target ends with multilib, please refer to the table below to see all the targets within that multilib.

Target name -march string
newlib-rv64gc-lp64d-multilib rv32gc-ilp32d, rv64gc-lp64d
newlib-rv64gcv-lp64d-multilib rv64gcv-lp64d
linux-rv64gcv-lp64d-multilib rv32gcv-ilp32d, rv64gcv-lp64d

Target Information

Target Shorthand -march string
Bitmanip gc_zba_zbb_zbc_zbs

Notes

Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist.
Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our
gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours.
If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com

Copy link
Author

github-actions bot commented Feb 27, 2024

Lint Status

The following issues have been found with 31354-RISCV_Add_XiangShan_Nanhu_microarchitecture-1 using gcc's ./contrib/check_GNU_style.py.
Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.

=== ERROR type #1: blocks of 8 spaces should be replaced with tabs (1 error(s)) ===
gcc/config/riscv/riscv.cc:514:38:  RISCV_FUSE_ZEXTW | RISCV_FUSE_ZEXTH,████████  /* fusible_ops */

=== ERROR type #2: dot, space, space, end of comment (13 error(s)) ===
gcc/config/riscv/riscv.cc:503:51:  {COSTS_N_INSNS (3), COSTS_N_INSNS (3)},	/* fp_add */
gcc/config/riscv/riscv.cc:504:51:  {COSTS_N_INSNS (3), COSTS_N_INSNS (3)},	/* fp_mul */
gcc/config/riscv/riscv.cc:505:53:  {COSTS_N_INSNS (10), COSTS_N_INSNS (20)},	/* fp_div */
gcc/config/riscv/riscv.cc:506:52:  {COSTS_N_INSNS (3), COSTS_N_INSNS (3)},	/* int_mul */
gcc/config/riscv/riscv.cc:507:52:  {COSTS_N_INSNS (6), COSTS_N_INSNS (6)},	/* int_div */
gcc/config/riscv/riscv.cc:508:23:  6,						/* issue_rate */
gcc/config/riscv/riscv.cc:509:24:  3,						/* branch_cost */
gcc/config/riscv/riscv.cc:510:24:  3,						/* memory_cost */
gcc/config/riscv/riscv.cc:511:21:  3,						/* fmv_cost */
gcc/config/riscv/riscv.cc:512:37:  true,						/* slow_unaligned_access */
gcc/config/riscv/riscv.cc:513:36:  false,					/* use_divmod_expansion */
gcc/config/riscv/riscv.cc:514:62:  RISCV_FUSE_ZEXTW | RISCV_FUSE_ZEXTH,          /* fusible_ops */
gcc/config/riscv/riscv.cc:515:27:  NULL,						/* vector cost */

=== ERROR type #3: lines should not exceed 80 characters (2 error(s)) ===
gcc/config/riscv/xiangshan.md:93:80:       (eq_attr "type" "nop,const,branch,arith,shift,slt,multi,logical,move,bitmanip,unknown"))
gcc/config/riscv/riscv.cc:512:80:  true,                                                /* slow_unaligned_access */

=== ERROR type #4: there should be exactly one space between function name and parenthesis (2 error(s)) ===
gcc/config/riscv/riscv-cores.def:43:10:RISCV_TUNE("xiangshan-nanhu", xiangshan, xiangshan_nanhu_tune_info)
gcc/config/riscv/riscv-cores.def:95:10:RISCV_CORE("xiangshan-nanhu",      "rv64imafdc_zba_zbb_zbc_zbs_"

Additional information

Copy link
Author

github-actions bot commented Feb 27, 2024

Apply Status

Target Status
Baseline hash: gcc-mirror/gcc@2f71e80 Applied
Tip of tree hash: gcc-mirror/gcc@15d1dae Applied

Notes

Patch applied successfully

Additional information

@github-actions github-actions bot added the linter-failure Lint failed label Feb 27, 2024
Copy link
Author

github-actions bot commented Feb 27, 2024

Build GCC Status

Target Status
newlib-rv64gcv-lp64d-multilib Success
linux-rv64gcv-lp64d-multilib Success
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib Success
newlib-rv64gc-lp64d-multilib Success
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib Success

Notes

Patch(es) were applied to the hash gcc-mirror/gcc@2f71e80. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.

Additional information

Copy link
Author

github-actions bot commented Feb 27, 2024

Testsuite Status

Summary

New Failures gcc g++ gfortran Previous Hash
Resolved Failures gcc g++ gfortran Previous Hash
Unresolved Failures gcc g++ gfortran Previous Hash
linux: rv32 Bitmanip ilp32d medlow 165/40 8/2 12/2 gcc-mirror/gcc@2f71e80
linux: rv32gcv ilp32d medlow multilib 189/59 12/3 15/3 gcc-mirror/gcc@2f71e80
linux: rv64 Bitmanip lp64d medlow 164/39 8/2 12/2 gcc-mirror/gcc@2f71e80
linux: rv64gcv lp64d medlow multilib 186/57 12/3 12/2 gcc-mirror/gcc@2f71e80
newlib: rv32gc ilp32d medlow multilib 195/45 61/8 0/0 gcc-mirror/gcc@2f71e80
newlib: rv64gc lp64d medlow multilib 186/42 37/6 0/0 gcc-mirror/gcc@2f71e80
newlib: rv64gcv lp64d medlow multilib 203/56 41/7 0/0 gcc-mirror/gcc@2f71e80

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter-failure Lint failed
Projects
None yet
Development

No branches or pull requests

0 participants