Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Status 35238-RFCv3_RISCV_Promote_ZaamoZalrsc_to_a_when_using_an_old_binutils-1 #1760

Open
github-actions bot opened this issue Jun 18, 2024 · 4 comments

Comments

@github-actions
Copy link

Precommit CI Run information

Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/9557470304

Patch information

Applied patches: 1 -> 1
Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=35238
Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/20240618000230.2784484-1-patrick@rivosinc.com/
Patch id: 92321

Build Targets

Some targets are built as multilibs. If a build target ends with multilib, please refer to the table below to see all the targets within that multilib.

Target name -march string
newlib-rv64gc-lp64d-multilib rv32gc-ilp32d, rv64gc-lp64d
newlib-rv64gcv-lp64d-multilib rv64gcv-lp64d
linux-rv64gcv-lp64d-multilib rv32gcv-ilp32d, rv64gcv-lp64d

Target Information

Target Shorthand -march string
Bitmanip gc_zba_zbb_zbc_zbs

Notes

Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist.
Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our
gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours.
If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com

Copy link
Author

github-actions bot commented Jun 18, 2024

Lint Status

The following issues have been found with 35238-RFCv3_RISCV_Promote_ZaamoZalrsc_to_a_when_using_an_old_binutils-1 using gcc's ./contrib/check_GNU_style.py.
Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.

=== ERROR type #1: dot, space, space, end of comment (11 error(s)) ===
gcc/common/config/riscv/riscv-common.cc:1973:54:  const std::string arch = riscv_arch_str (/*version_p*/ false, upgrade_exts);
gcc/common/config/riscv/riscv-common.cc:1984:54:  return riscv_expand_arch (argc, argv, /*upgrade_exts*/ true);
gcc/common/config/riscv/riscv-common.cc:1991:54:  return riscv_expand_arch (argc, argv, /*upgrade_exts*/ false);
gcc/common/config/riscv/riscv-common.cc:2037:54:  const std::string arch = riscv_arch_str (/*version_p*/ false, upgrade_exts);
gcc/common/config/riscv/riscv-common.cc:2045:63:  return riscv_expand_arch_from_cpu (argc, argv, /*upgrade_exts*/ true);
gcc/common/config/riscv/riscv-common.cc:2052:63:  return riscv_expand_arch_from_cpu (argc, argv, /*upgrade_exts*/ false);
gcc/config/riscv/riscv-target-attr.cc:371:41:			   subset_list->to_string (/*version_p*/ true,
gcc/config/riscv/riscv-target-attr.cc:372:23:						   /*upgrade_exts*/ true));
gcc/config/riscv/riscv.cc:9431:31:	   riscv_arch_str (/*version_p*/ true, /*upgrade_exts*/ true).c_str ());
gcc/config/riscv/riscv.cc:9473:55:	: riscv_cmdline_subset_list ()->to_string (/*version_p*/ true,
gcc/config/riscv/riscv.cc:9474:23:						   /*upgrade_exts*/ true);

=== ERROR type #2: dot, space, space, new sentence (1 error(s)) ===
gcc/config/riscv/riscv.cc:9429:8:     Eg.█Zalrsc -> a.  */

=== ERROR type #3: lines should not exceed 80 characters (11 error(s)) ===
gcc/config/riscv/riscv.h:55:80:                                                               const char **argv);
gcc/config/riscv/riscv.h:60:80:# define EXTRA_SPEC_FUNCTIONS                                                           \
gcc/config/riscv/riscv.h:61:80:  { "riscv_expand_arch_u", riscv_expand_arch_upgrade_exts },                           \
gcc/config/riscv/riscv.h:62:80:  { "riscv_expand_arch_nu", riscv_expand_arch_no_upgrade_exts },                   \
gcc/config/riscv/riscv.h:63:80:  { "riscv_expand_arch_from_cpu_nu", riscv_expand_arch_from_cpu_no_upgrade_exts }, \
gcc/config/riscv/riscv.h:64:80:  { "riscv_expand_arch_from_cpu_u", riscv_expand_arch_from_cpu_upgrade_exts },           \
gcc/config/riscv/riscv.h:65:80:  { "riscv_default_mtune", riscv_default_mtune },                                   \
gcc/config/riscv/riscv.h:66:80:  { "riscv_multi_lib_check", riscv_multi_lib_check },                                   \
gcc/config/riscv/riscv.h:80:80:           "  %{mcpu=*:-mtune=%:riscv_default_mtune(%* %(VALUE))}}" },          \
gcc/config/riscv/riscv.h:85:80:  {"isa_spec", "%{!misa-spec=*:-misa-spec=%(VALUE)}" },                          \
gcc/config/riscv/riscv.h:86:80:  {"tls", "%{!mtls-dialect=*:-mtls-dialect=%(VALUE)}"},                          \

=== ERROR type #4: there should be exactly one space between function name and parenthesis (6 error(s)) ===
gcc/config/riscv/riscv.h:80:44:	   "  %{mcpu=*:-mtune=%:riscv_default_mtune(%* %(VALUE))}}" },	  \
gcc/config/riscv/riscv.h:83:47:	   "  %{mcpu=*:%:riscv_expand_arch_from_cpu_nu(%* %(VALUE))}}" }, \
gcc/config/riscv/riscv.h:113:31:%{march=*:%:riscv_expand_arch_u(%*)} \
gcc/config/riscv/riscv.h:114:50:%{!march=*:%{mcpu=*:%:riscv_expand_arch_from_cpu_u(%*)}} \
gcc/config/riscv/riscv.h:127:33:"%{march=*:%:riscv_expand_arch_nu(%*)} "			\
gcc/config/riscv/riscv.h:128:52:"%{!march=*:%{mcpu=*:%:riscv_expand_arch_from_cpu_nu(%*)}} "

Additional information

Copy link
Author

github-actions bot commented Jun 18, 2024

Apply Status

Target Status
Baseline hash: gcc-mirror/gcc@3dedfad Failed
Tip of tree hash: gcc-mirror/gcc@7c6f79e Applied

Git log

git log --oneline from the most recently applied patch to the baseline

> git log --oneline 7c6f79eea9febce3b21c5783bac9b0a36e08f003^..HEAD
1a61fa023ae RISC-V: Promote Zaamo/Zalrsc to a when using an old binutils
7c6f79eea9f i386: Handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx

Notes

Failed to apply to the post-commit baseline. This can happen
if your commit requires a recently-commited patch in order to apply.
The pre-commit CI will only perform a build since it doesn't know what
dejagnu testsuite failures are expected on the tip-of-tree.

If you would like us to re-run this patch once the baseline reaches a
different hash, please email us at patchworks-ci@rivosinc.com with a link
to your patch.

Additional information

Copy link
Author

github-actions bot commented Jun 18, 2024

Build GCC Status

Target Status
newlib-rv32imc_zba_zbb_zbc_zbs-ilp32d-non-multilib Success
newlib-rv64gc-lp64d-multilib Success
linux-rv64gcv-lp64d-multilib Success
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib Success
newlib-rv64gcv-lp64d-multilib Success
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib Success

Notes

Patch(es) were applied to the hash gcc-mirror/gcc@7c6f79e. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.

Additional information

Copy link
Author

Testsuite Status

Testsuite tests were skipped. Patch did not apply to baseline hash gcc-mirror/gcc@3dedfad. No comparison applicable.

Additional information

@github-actions github-actions bot added the linter-failure Lint failed label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants