Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Status 27727-RISCV_Vectorized_strncmp_and_strlen-1 #804

Closed
github-actions bot opened this issue Nov 30, 2023 · 4 comments
Closed

Patch Status 27727-RISCV_Vectorized_strncmp_and_strlen-1 #804

github-actions bot opened this issue Nov 30, 2023 · 4 comments

Comments

@github-actions
Copy link

Precommit CI Run information

Logs can be found in the associated Github Actions run: https://github.com/ewlu/gcc-precommit-ci/actions/runs/7053042110

Patch information

Applied patches: 1 -> 1
Associated series: https://patchwork.sourceware.org/project/gcc/list/?series=27727
Last patch applied: https://patchwork.sourceware.org/project/gcc/patch/2cf2fa3f-541b-4c39-8689-161c7a047f7a@gmail.com/
Patch id: 81062

Build Targets

Some targets are built as multilibs. If a build target ends with multilib, please refer to the table below to see all the targets within that multilib.

Target name -march string
newlib-rv64gc-lp64d-multilib rv32gc-ilp32d, rv64gc-lp64d
newlib-rv64gcv-lp64d-multilib rv64gcv-lp64d
linux-rv64gcv-lp64d-multilib rv32gcv-ilp32d, rv64gcv-lp64d

Target Information

Target Shorthand -march string
Bitmanip gc_zba_zbb_zbc_zbs

Notes

Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current allowlist.
Results come from a sum file comparator. Each patch is applied to a well known, non-broken baseline taken from our
gcc postcommit framework (here) which runs the full gcc testsuite every 6 hours.
If you have any questions or encounter any issues which may seem like false-positives, please contact us at patchworks-ci@rivosinc.com

Copy link
Author

github-actions bot commented Nov 30, 2023

Lint Status

The following issues have been found with 27727-RISCV_Vectorized_strncmp_and_strlen-1 using gcc's ./contrib/check_GNU_style.py.
Please use your best judgement when resolving these issues. These are only warnings and do not need to be resolved in order to merge your patch.
If any of these warnings seem like false-positives that could be guarded against please contact me: patchworks-ci@rivosinc.com.

=== ERROR type #1: dot, space, space, end of comment (6 error(s)) ===
gcc/config/riscv/riscv-opts.h:106:27:/* RISC-V builtin strategy.█*/
gcc/config/riscv/riscv-opts.h:108:18:  /* No expansion.█*/
gcc/config/riscv/riscv-opts.h:110:38:  /* Use scalar expansion if possible.█*/
gcc/config/riscv/riscv-opts.h:112:39:  /* Only vector expansion if possible.█*/
gcc/config/riscv/riscv-opts.h:114:13:  /* Use any.█*/
gcc/config/riscv/riscv-string.cc:603:19:				      /* strlen */ true);

=== ERROR type #2: lines should not exceed 80 characters (4 error(s)) ===
gcc/config/riscv/riscv-string.cc:1095:80:      emit_insn (gen_rtx_SET (end, gen_rtx_ASHIFT (Pmode, end, GEN_INT (shift))));
gcc/config/riscv/riscv-string.cc:1226:80:  emit_insn (gen_rtx_SET (src_addr1, gen_rtx_PLUS (Pmode, src_addr1, found_at)));
gcc/config/riscv/riscv-string.cc:1227:80:  emit_insn (gen_rtx_SET (src_addr2, gen_rtx_PLUS (Pmode, src_addr2, found_at)));
gcc/config/riscv/riscv.opt:555:80:Target RejectNegative Joined Enum(stringop_strategy) Var(stringop_strategy) Init(STRINGOP_STRATEGY_AUTO)

=== ERROR type #3: there should be exactly one space between function name and parenthesis (6 error(s)) ===
gcc/config/riscv/riscv.opt:539:4:Name(stringop_strategy) Type(enum stringop_strategy_enum)
gcc/config/riscv/riscv.opt:543:4:Enum(stringop_strategy) String(auto) Value(STRINGOP_STRATEGY_AUTO)
gcc/config/riscv/riscv.opt:546:4:Enum(stringop_strategy) String(libcall) Value(STRINGOP_STRATEGY_LIBCALL)
gcc/config/riscv/riscv.opt:549:4:Enum(stringop_strategy) String(scalar) Value(STRINGOP_STRATEGY_SCALAR)
gcc/config/riscv/riscv.opt:552:4:Enum(stringop_strategy) String(vector) Value(STRINGOP_STRATEGY_VECTOR)
gcc/config/riscv/riscv.opt:555:33:Target RejectNegative Joined Enum(stringop_strategy) Var(stringop_strategy) Init(STRINGOP_STRATEGY_AUTO)

Additional information

Copy link
Author

github-actions bot commented Nov 30, 2023

Apply Status

Target Status
Baseline hash: gcc-mirror/gcc@303195e Applied
Tip of tree hash: gcc-mirror/gcc@725c68c Applied

Notes

Patch applied successfully

Additional information

@github-actions github-actions bot added the linter-failure Lint failed label Nov 30, 2023
Copy link
Author

github-actions bot commented Nov 30, 2023

Build GCC Status

Target Status
newlib-rv64gc-lp64d-multilib Success
newlib-rv64gcv-lp64d-multilib Success
linux-rv64gcv-lp64d-multilib Success
linux-rv64gc_zba_zbb_zbc_zbs-lp64d-non-multilib Success
linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-non-multilib Success

Notes

Patch(es) were applied to the hash gcc-mirror/gcc@303195e. If this patch commit depends on or conflicts with a recently committed patch, then these results may be outdated.

Additional information

Copy link
Author

github-actions bot commented Nov 30, 2023

Testsuite Status

Summary

New Failures gcc g++ gfortran Previous Hash
linux: rv32 Bitmanip ilp32d medlow 5/5 0/0 0/0 gcc-mirror/gcc@303195e
linux: rv32gcv ilp32d medlow multilib 5/5 0/0 0/0 gcc-mirror/gcc@303195e
linux: rv64 Bitmanip lp64d medlow 5/5 0/0 0/0 gcc-mirror/gcc@303195e
linux: rv64gcv lp64d medlow multilib 5/5 0/0 0/0 gcc-mirror/gcc@303195e
newlib: rv32gc ilp32d medlow multilib 5/5 0/0 0/0 gcc-mirror/gcc@303195e
newlib: rv64gc lp64d medlow multilib 5/5 0/0 0/0 gcc-mirror/gcc@303195e
newlib: rv64gcv lp64d medlow multilib 15/6 0/0 0/0 gcc-mirror/gcc@303195e
Resolved Failures gcc g++ gfortran Previous Hash
Unresolved Failures gcc g++ gfortran Previous Hash
linux: rv32 Bitmanip ilp32d medlow 99/84 41/26 13/3 gcc-mirror/gcc@303195e
linux: rv32gcv ilp32d medlow multilib 110/98 47/29 18/6 gcc-mirror/gcc@303195e
linux: rv64 Bitmanip lp64d medlow 29/14 15/6 12/2 gcc-mirror/gcc@303195e
linux: rv64gcv lp64d medlow multilib 39/29 19/7 14/4 gcc-mirror/gcc@303195e
newlib: rv32gc ilp32d medlow multilib 80/23 108/16 0/0 gcc-mirror/gcc@303195e
newlib: rv64gc lp64d medlow multilib 69/18 81/12 0/0 gcc-mirror/gcc@303195e
newlib: rv64gcv lp64d medlow multilib 74/30 85/13 0/0 gcc-mirror/gcc@303195e

New Failures Across All Affected Targets (7 targets / 7 total targets)

FAIL: gcc.target/riscv/rvv/base/cpymem-strategy-1.c (test for excess errors)
FAIL: gcc.target/riscv/rvv/base/cpymem-strategy-2.c (test for excess errors)
FAIL: gcc.target/riscv/rvv/base/cpymem-strategy-3.c (test for excess errors)
FAIL: gcc.target/riscv/rvv/base/cpymem-strategy-4.c (test for excess errors)
FAIL: gcc.target/riscv/rvv/base/cpymem-strategy-5.c (test for excess errors)

Architecture Specific New Failures

newlib rv64gcv lp64d medlow multilib:

FAIL: gcc.target/riscv/rvv/autovec/builtin/strcmp-run.c execution test

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants