fix: don't mutate default options of Seller

ewngs · Oct 19, 2023 · 78dc213 · 78dc213
1 parent 36a3d8d
commit 78dc213
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/Seller.js b/lib/Seller.js
@@ -8,7 +8,7 @@ const defaultOptions = {
 
 export class Seller {
   constructor (options) {
-    this._options = merge.recursive(defaultOptions, options || {})
+    this._options = merge.recursive(true, defaultOptions, options || {})
   }
 
   _generateXML (indentLevel) {

diff --git a/tests/seller.spec.js b/tests/seller.spec.js
@@ -19,6 +19,18 @@ describe('Seller', function () {
     it('should set _options property', function () {
       expect(seller).to.have.property('_options').that.is.an('object')
     })
+
+    it('should not mutate options', function () {
+      const seller = new Seller({})
+      const expected = {
+        _options: {
+          bank: {},
+          email: {}
+        }
+      }
+
+      expect(seller).to.be.deep.equal(expected)
+    })
   })
 
   describe('_generateXML', function () {