Support Fetching Credentials with AssumeRoleCredentials based on role_arn in awscli config #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @arnomi! |
|
This is really cool, I need this, thanks @arnomi! |
|
@benwilson512 I guess you are pretty busy at the moment, but could you provide an estimate as to when you get to looking over the current pull requests? Thanks a lot for all your efforts and the great work you are doing on ex_aws (and other libs). |
|
Hey folks, my apologies on the delay, this is a great design. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for an adapted implementation for #502.
Here an authentication now provides an extension point which can be implemented to adapt the authentication information. An implementation of this extension point is given in ex_aws_sts which handles the AssumeRoleCredentials operation. A pull request has been opened there as well.
A lot of thanks to @bundacia and @mlagutko for the original implementation which I built upon.
Looking forward to comments.
Thanks
@arnomi