Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow STS credentials to be injected by configuration #22

Conversation

carrascoacd
Copy link
Contributor

Problem

In order to make ex_aws fully production-ready, we need to take into account the containerized applications that run, for example, over Kubernetes or Nomad. A typical configuration of secrets for this kind of application is by injection using environment variables. It is very common to restrict write permissions on the file system to avoid security problems also.

The aforementioned facts enter in conflict with the design of the STS module which resides on a file system file in order to assume a role for example.

Proposed solution

Use the new way of fetching the credentials without coupling the retrieval to a file in the filesystem. Follow the upstream PR to understand the changes:
ex-aws/ex_aws#747

@carrascoacd
Copy link
Contributor Author

cc/ @vanetix

@vanetix
Copy link
Collaborator

vanetix commented Mar 7, 2021

Thanks @carrascoacd I'll take a look at this tonight or tomorrow morning!

@vanetix
Copy link
Collaborator

vanetix commented Mar 8, 2021

Good work, I really like this addition! I'll wait for the ex-aws/ex_aws#747 to get merged up and I'll merge this in and bump a minor version.

@bernardd
Copy link

Hi @vanetix - I've just published ex_aws 2.2.0 which has support for this change. Apologies for the delay.

@vanetix
Copy link
Collaborator

vanetix commented Apr 21, 2021

Hi @vanetix - I've just published ex_aws 2.2.0 which has support for this change. Apologies for the delay.

No worries @bernardd I'll be pretty busy here for the near future but please let me know if there is anything I can do to help out on the core ex_aws work!

@vanetix
Copy link
Collaborator

vanetix commented Apr 21, 2021

Thanks again @carrascoacd! I'll go ahead and merge this. I need to get with @koozdra to get another PR with a version bump / publish to hex.pm.

@vanetix vanetix merged commit 6ac699b into ex-aws:master Apr 21, 2021
@carrascoacd
Copy link
Contributor Author

@vanetix if you need help with the bump version I can create the PR even updating the doc to reflect the new way.

@vanetix
Copy link
Collaborator

vanetix commented May 7, 2021

@vanetix if you need help with the bump version I can create the PR even updating the doc to reflect the new way.

That would be awesome, that would let me approve + merge. Sorry this slipped my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants