Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruby syntax highlighted code blocks #29

Closed
wants to merge 1 commit into from

Conversation

vfonic
Copy link

@vfonic vfonic commented Jul 25, 2019

I understand that the <pre> blocks might have been done on purpose, however, I find it much easier to read syntax highlighted blocks and I thought other developers might as well.

But I can see the benefit of being able to bold specific changes (although there's not a lot of code in there, so maybe syntax highlighting after all? :D ), feel free to reject this PR.

Thanks!

EDIT: You can preview the new readme here: https://github.com/exAspArk/graphql-guard/blob/f4184b0a3a09121dd858a17929b3b88919ea23a9/README.md

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f4184b0 on vfonic:patch-1 into fb2ebb3 on exAspArk:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f4184b0 on vfonic:patch-1 into fb2ebb3 on exAspArk:master.

@ghost
Copy link

ghost commented Aug 8, 2019

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@ghost ghost added the stale Inactive label Aug 8, 2019
@vfonic
Copy link
Author

vfonic commented Aug 8, 2019

@exAspArk did you get the chance to look at this? Thanks!

@ghost ghost removed the stale Inactive label Aug 8, 2019
@exAspArk
Copy link
Owner

exAspArk commented Aug 9, 2019

Hey @vfonic,

Yeah, I intentionally wanted to highlight the important parts of the code examples. Unfortunately, GitHub doesn't allow enabling syntax highlighting with highlighting some pieces of the code: increasing text width, underlining, configure opacity, etc. In this particular case, I prefer highlighting specific parts of the code over general syntax highlighting.

Thank you for opening the PR though! 🙌

@exAspArk exAspArk closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants