Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 168 #199

Merged
merged 24 commits into from
Apr 8, 2020
Merged

Issue 168 #199

merged 24 commits into from
Apr 8, 2020

Conversation

tjduigna
Copy link
Contributor

Opening this to throw some ideas around about possible implementations for data <-> container functionality.

@tjduigna tjduigna added the 1.0 label Mar 30, 2020
exa/core/box.py Outdated Show resolved Hide resolved
exa/core/box.py Outdated Show resolved Hide resolved
exa/core/data.py Outdated Show resolved Hide resolved
exa/core/box.py Outdated Show resolved Hide resolved
@avmarchenko
Copy link
Member

I took the liberty of resolving the conflict in .travis.yml. Hopefully I did it correctly...

Copy link
Member

@avmarchenko avmarchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments on box and data. I'd appreciate your feedback/thoughts (even if no code changes are ultimately made) before we merge. For my own learning, what is a .qet file?

appveyor.yml Outdated Show resolved Hide resolved
exa/__init__.py Outdated Show resolved Hide resolved
exa/core/box.py Show resolved Hide resolved
exa/core/box.py Outdated Show resolved Hide resolved

def memory(self):
pass

def network(self):
pass
"""Build a network of the relationships between
data as specified by the container's metadata.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the relationships are being built by the data itself (assumes that the data is DataFrame or Series? object and constructs based on series names).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the network I was hoping that it would be possible to generate some (if not all) of the relationships based solely on the Data's metadata, rather than having to descend to the underlying data and inspect it directly. I see this approach not working great where multiple index-column relations exist, e.g. atom -> atom0, atom1.

exa/core/box.py Show resolved Hide resolved
API should live in and be controlled by the Container?
Here can serve as a pass-through to parent if it exists.
Should it need to be present in data?
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a really good idea. When a data object is attached to a container, does the data object have a reference to its container?

@tjduigna tjduigna merged commit ef4633e into exa-analytics:feature/1.0 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants