Command parsing regression in certain versions

[thomas-mangin]

From justin.a...@gmail.com on August 22, 2013 14:11:32

The issue:

Thu, 22 Aug 2013 09:09:54 | INFO | 6603 | processes | Command from process service-2 : announce route 192.0.2.1 next-hop 10.0.0.1 community [ no-export ]
Thu, 22 Aug 2013 09:09:54 | WARNING | 6603 | supervisor | Command could not parse route in : announce route 192.0.2.1 next-hop 10.0.0.1 community [ no-export ]

Versions with the issue:
It looks like:

3.1.4+: bug
3 .1.3: OK Could reproduce the problem on the latest development version ? No!

3.2.0: bug
3 .2.1+: ok
tip: ok How we could reproduce the problem? echo "announce route 192.0.2.1 next-hop 10.0.0.1 community [ no-export ]" Please provide any additional information below. Changing the process to do

echo "announce route 192.0.2.1 next-hop 10.0.0.1 community [no-export]"

is a workaround for the released exabgp versions.

According to hg bisect:

The first good revision is:
changeset: 1435:5da0b0b616bb
user: Thomas Mangin thomas.mangin@exa-networks.co.uk
date: Tue Jul 16 23:03:57 2013 +0100
files: CHANGELOG lib/exabgp/configuration/file.py
description:
fix bug with extra spaces in the configuration file

but I see that that related code changed a number of times, and I keep making a mess of hg bisect trying to figure out just what the problem/fix was.

Not sure what the fix here would be.. The workaround is fine for me, but others might run into this if they upgrade from an older version to 3.1.x like I did.

Original issue: http://code.google.com/p/exabgp/issues/detail?id=47

[thomas-mangin]

From thomas.mangin on August 23, 2013 07:40:22

I could release a 3.1.14 but a 3.2.x release is imminent ... The mercurial tree is now again stable and contains MANY improvement over 3.1.x

I am sorry you had this issue - hope it did not affect any production environment, I did not realise the bug was not present in previous version.

Status: Accepted

[thomas-mangin]

From thomas.mangin on August 23, 2013 07:54:54

I take that back - I still need a few days to make sure 3.2 is ready.

[thomas-mangin]

From thomas.mangin on August 25, 2013 07:38:40

closing.

[thomas-mangin]

From thomas.mangin on August 25, 2013 07:39:09

Status: WontFix