-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alpine images on Swoole and Docker #77
Conversation
Thanks for your contribution! I think creating new Dockerfiles like |
It's my pleasure! This repo has saved me hours of my life, it's the least I can do. I'll go ahead and alter the PR to introduce those new files and keep the original ones untouched. |
@smortexa I have altered the PR to make the Alpine files separate! The start-container is still the same with the alteration of Line 1 |
This is a PR for issue #76, "add alpine images".
I have not altered the FrankenPHP.Dockerfile as I don't use FrankenPHP and am not sure which image to select or how to reliably test it.
The changes in this PR are pretty straightforward, and nearly identical on the RoadRunner and Swoole docker files.
Potential Issues:
#!/usr/bin/env sh
line on top of start-container will effect the FrankenPHP image.As for next steps, assuming everything works well on you guys' end, I'm not sure if it would be best to: