Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alpine images on Swoole and Docker #77

Merged
merged 12 commits into from
May 16, 2024
Merged

Conversation

dir
Copy link
Contributor

@dir dir commented May 15, 2024

This is a PR for issue #76, "add alpine images".

I have not altered the FrankenPHP.Dockerfile as I don't use FrankenPHP and am not sure which image to select or how to reliably test it.

The changes in this PR are pretty straightforward, and nearly identical on the RoadRunner and Swoole docker files.

Potential Issues:

  • not sure if changing the #!/usr/bin/env sh line on top of start-container will effect the FrankenPHP image.
  • haven't tested RoadRunner fully enough yet

As for next steps, assuming everything works well on you guys' end, I'm not sure if it would be best to:

  • Replace the original files
  • Create separate "alpine" branch/release
  • Add additional files to this repo

@smortexa
Copy link
Member

smortexa commented May 15, 2024

Thanks for your contribution! I think creating new Dockerfiles like Swoole.Alpine.Dockerfile instead of modifying our existing Debian-based Dockerfiles is a better idea. After that, we can think about moving Dockerfiles to a new directory and updating GitHub Actions.

@dir
Copy link
Contributor Author

dir commented May 15, 2024

It's my pleasure! This repo has saved me hours of my life, it's the least I can do.

I'll go ahead and alter the PR to introduce those new files and keep the original ones untouched.

@dir
Copy link
Contributor Author

dir commented May 15, 2024

@smortexa I have altered the PR to make the Alpine files separate!

The start-container is still the same with the alteration of Line 1
#!/usr/bin/env bash -> #!/usr/bin/env sh

@smortexa smortexa merged commit eb792c6 into exaco:main May 16, 2024
12 checks passed
@dir dir deleted the feat/alpine branch May 18, 2024 03:39
@dir dir restored the feat/alpine branch May 18, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants