-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor InterfaceCoupling #126
Conversation
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
This looks like a great simplification, now that we can get the data uniform. I guess we need some backward compatibility setting for deal.II 9.3 (I assume we could choose something similar as I did in #120 with a copy to |
9997ea8
to
9663938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, apart from the questions where we still need to decide.
include/exadg/functions_and_boundary_conditions/function_cached.h
Outdated
Show resolved
Hide resolved
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
include/exadg/functions_and_boundary_conditions/interface_coupling.h
Outdated
Show resolved
Hide resolved
@peterrum Many thanks for these changes. This PR is a good example of what we describe in ExaDG's readme under "Philosophy" (https://github.com/exadg/exadg#philosophy). |
These changes should be tested "manually" by running FSI examples which use this functionality. |
@nfehn Thanks for the review. I'll try to integrate the suggestions later today or tomorrow! |
@nfehn I have applied the comments. I have run the |
In principle, one example should be enough because the algorithm in terms of interface coupling is the same for all examples. However, since the cylinder example is a 2d example, it could make sense to run a 3d example as well, e.g. pressure_wave. |
...so that it uses
dealii::Utilities::MPI::RemotePointEvaluation
.depends on
dealii/dealii#13173, dealii/dealii#13177, dealii/dealii#13178, dealii/dealii#13187, #127