Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Compilation Errors #251

Closed
wants to merge 1 commit into from
Closed

Conversation

jh66637
Copy link
Contributor

@jh66637 jh66637 commented Jul 19, 2022

I think there are compilation errors related to explicitly using double and dealii/dealii#14142

@nfehn
Copy link
Member

nfehn commented Jul 19, 2022

hm, it is actually a design goal in ExaDG to keep Number out of data structures such as BoundaryDescriptor. I am not sure if the changes here are the way how we should approach this.

@jh66637
Copy link
Contributor Author

jh66637 commented Jul 19, 2022

I am currently just checking where the error comes from. I am not intending to keep all the changes

@jh66637
Copy link
Contributor Author

jh66637 commented Jul 19, 2022

@nfehn The problem is, that deal checks internally for double vs float. So instantiating InterfaceCoupling will fail. So you should not be allowed to call InterfaceCoupling and InterfaceCouplingData with Number==float in the first place if only doubles are supported inside.

@jh66637
Copy link
Contributor Author

jh66637 commented Jul 20, 2022

To be able to keep Number out, we need something like a copy of float data to double data. Or a major code refracturing. I might give it a try again towards the end of the week and create an Issue in the mean time.

@jh66637 jh66637 closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants