Skip to content

Commit

Permalink
Small trifles with cd plugin (#874)
Browse files Browse the repository at this point in the history
Small trifles with cd plugin
* Missing gettext
* Retrieving default format from formats list
* encode as mp3 needs to use lamemp3enc now
  • Loading branch information
luzip665 committed May 17, 2023
1 parent a5f25d0 commit 84c773f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions plugins/cd/_cdguipanel.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def __init__(self, tracks):

def __prepare_transcoder(self):
formats = transcoder.get_formats()
default_format = next(formats.keys())
default_format = next(iter(formats))
self.format = settings.get_option("cd_import/format", default_format)
default_quality = formats[default_format]['default']
self.quality = settings.get_option("cd_import/quality", default_quality)
Expand Down Expand Up @@ -184,7 +184,7 @@ def do_import(self):

def _end_cb(self):
self.cont.set()
xlgui.main.mainwindow().message.show_info("Finished transcoding files")
xlgui.main.mainwindow().message.show_info(_("Finished transcoding files"))

def _error_cb(self, gerror, message_string):
self.running = False
Expand Down
4 changes: 2 additions & 2 deletions xl/transcoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"default" : 160,
"raw_steps" : [32, 48, 64, 96, 128, 160, 192, 224, 256, 320],
"kbs_steps" : [32, 48, 64, 96, 128, 160, 192, 224, 256, 320],
"command" : "lame vbr=4 vbr-mean-bitrate=%i",
"command" : "lamemp3enc vbr=4 vbr-mean-bitrate=%i",
"extension" : "mp3",
"plugins" : ["lamemp3enc"],
"desc" : _("A proprietary and older, but also popular, lossy "
Expand All @@ -96,7 +96,7 @@
"default" : 160,
"raw_steps" : [32, 48, 64, 96, 128, 160, 192, 224, 256, 320],
"kbs_steps" : [32, 48, 64, 96, 128, 160, 192, 224, 256, 320],
"command" : "lame bitrate=%i",
"command" : "lamemp3enc bitrate=%i",
"extension" : "mp3",
"plugins" : ["lamemp3enc"],
"desc" : _("A proprietary and older, but also popular, "
Expand Down

0 comments on commit 84c773f

Please sign in to comment.