Translation on windows fails #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On linux the manual setting of os.environ['LANGUAGE'] works. May help: tobias47n9e/pygobject-locale#1 (comment) |
|
Seems to be a more general problem |
|
Still not translated:
|
luzip665
force-pushed
the
translation_on_windows
branch
from
3c353e3
to
c955d72
Compare
|
Everything gets translated now. May be there are better ways to implement the translation of the ui-xml especially for GtkTemplate. |
sjohannes
reviewed
Jan 22, 2022
luzip665
force-pushed
the
translation_on_windows
branch
from
b5d0482
to
b68a1be
Compare
* Setting os.environ['lang'] to locale.getlocale on win32 * Load Gtk.Builder with translation in guiutil.get_builder * Adding new cli-option --use-lang to set custom language
luzip665
force-pushed
the
translation_on_windows
branch
from
d033624
to
dad5492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: On german Windows exaile speaks english.
I added setting os.environ['LANG'] which helps mostly.
Only the main menu isn't translated yet.
Additionally, because it depends on windows, it solves #799
fixes: #799
fixes: #51