Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Evaluators] Improve compile time by fixing type inference issue #98

Merged
merged 1 commit into from
Feb 12, 2021
Merged

[Evaluators] Improve compile time by fixing type inference issue #98

merged 1 commit into from
Feb 12, 2021

Conversation

frapac
Copy link
Member

@frapac frapac commented Feb 10, 2021 •
edited
Loading

Before that PR, the compile time was on Julia 1.6:

julia> @time ExaPF.hessprod!(nlp, hv, u, v)
106.405218 seconds (490.52 M allocations: 30.982 GiB, 6.66% gc time, 99.99% compilation time)

After that PR:

julia> @time ExaPF.hessprod!(nlp, hv, u, v)
  6.306416 seconds (6.84 M allocations: 388.304 MiB, 3.07% gc time, 99.91% compilation time)

For some reason, the compile time is still reasonable in Julia 1.5.3...

@frapac
evaluator: fix issue with type inference on Julia 1.6
fcd8959 
* polar: remove hard-coded field AT
* update test/perf.jl script
* cleaning
@frapac frapac merged commit fcd8959 into develop Feb 12, 2021
@frapac frapac deleted the fp/type_inference branch February 16, 2021 18:04
@frapac frapac mentioned this pull request Apr 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel2323 michel2323 michel2323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frapac @michel2323