Allow to use other preconditioners than ICFS #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngdae
reviewed
Dec 22, 2020
| @@ -4,7 +4,7 @@ mutable struct ExaTronProblem{VI, VD} | |||
| nnz_a::Integer # number of Hessian entries in the strict lower | |||
| A::AbstractTronMatrix | |||
| B::AbstractTronMatrix | |||
| L::AbstractTronMatrix | |||
| L::AbstractPreconditionner | |||
| indfree::VI # a working array of dimension n | |||
There was a problem hiding this comment.
We might want to change variable name, since it is not just a lower triangular matrix now and has L inside.
There was a problem hiding this comment.
That makes sense. Would you prefer P, or something more explicit, as precond?
There was a problem hiding this comment.
I do not mind what it is called, as long as it is not L.
youngdae
reviewed
Dec 23, 2020
frapac
force-pushed
the
fp/preconditioners
branch
from
1110c05
to
1fed1a7
Compare
frapac
force-pushed
the
fp/preconditioners
branch
from
1fed1a7
to
bc150f8
Compare
|
@youngdae do you think we could merge this PR into master? |
Sorry, I was a bit behind. I'll merge it soon. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.