Skip to content

Commit

Permalink
Apply review suggestions.
Browse files Browse the repository at this point in the history
  • Loading branch information
morazow committed Oct 23, 2020
1 parent f7f3fe1 commit b8a2a55
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
16 changes: 8 additions & 8 deletions doc/changes/changes_0.9.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@

### Runtime Dependency Updates

* Updated ``org.apache.orc:orc-core`` from `1.6.4` to `1.6.5`.
* Updated ``org.apache.parquet:parquet-hadoop`` from `1.10.1` to `1.11.1`.
* Updated ``com.fasterxml.jackson.core:jackson-core`` from `2.11.2` to `2.11.3`.
* Updated ``com.fasterxml.jackson.core:jackson-databind`` from `2.11.2.3` to `2.11.3`.
* Updated ``com.fasterxml.jackson.core:jackson-annotations`` from `2.11.2` to `2.11.3`.
* Updated ``com.fasterxml.jackson.module:"jackson-module-scala`` from `2.11.2` to `2.11.3`.
* Updated `org.apache.orc:orc-core` from `1.6.4` to `1.6.5`.
* Updated `org.apache.parquet:parquet-hadoop` from `1.10.1` to `1.11.1`.
* Updated `com.fasterxml.jackson.core:jackson-core` from `2.11.2` to `2.11.3`.
* Updated `com.fasterxml.jackson.core:jackson-databind` from `2.11.2.3` to `2.11.3`.
* Updated `com.fasterxml.jackson.core:jackson-annotations` from `2.11.2` to `2.11.3`.
* Updated `com.fasterxml.jackson.module:"jackson-module-scala` from `2.11.2` to `2.11.3`.

### Test Dependency Updates

* Updated ``org.mockito:mockito-core`` from `3.5.13` to `3.5.15`.
* Updated `org.mockito:mockito-core` from `3.5.13` to `3.5.15`.

### Plugin Updates

* Updated ``com.github.cb372:sbt-explicit-dependencies`` from `0.2.13` to `0.2.15`.
* Updated `com.github.cb372:sbt-explicit-dependencies` from `0.2.13` to `0.2.15`.
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,8 @@ class RowRootConverter(schema: GroupType) extends GroupConverter {
override def end(): Unit = {}

private def makeReader(primitiveType: PrimitiveType, idx: Int): Converter = {
val typeName = primitiveType.getPrimitiveTypeName
val originalType = primitiveType.getOriginalType

typeName match {
primitiveType.getPrimitiveTypeName() match {
case PrimitiveTypeName.INT32 =>
originalType match {
case OriginalType.DATE => new RowDateConverter(this, idx)
Expand All @@ -96,7 +94,6 @@ class RowRootConverter(schema: GroupType) extends GroupConverter {
case PrimitiveTypeName.BOOLEAN => new RowPrimitiveConverter(this, idx)
case PrimitiveTypeName.DOUBLE => new RowPrimitiveConverter(this, idx)
case PrimitiveTypeName.FLOAT => new RowPrimitiveConverter(this, idx)

case PrimitiveTypeName.BINARY =>
originalType match {
case OriginalType.UTF8 => new RowStringConverter(this, idx)
Expand Down

0 comments on commit b8a2a55

Please sign in to comment.