Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move adapter property IS_LOCAL #85

Closed
ckunki opened this issue Nov 29, 2022 · 0 comments · Fixed by #107
Closed

Move adapter property IS_LOCAL #85

ckunki opened this issue Nov 29, 2022 · 0 comments · Fixed by #107
Assignees
@kaklakariada @ckunki
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Nov 29, 2022 •
edited

Move definition, implementation and documentation of adapter property IS_LOCAL

  • from virtual-schema-common-java/com.exasol.adapter.AdapterProperties
  • to exasol-virtual-schema

This deprecates the following fields and methods of virtual-schema-common-java/com.exasol.adapter.AdapterProperties:

public static final String IS_LOCAL_PROPERTY
public boolean isLocalSource()
public boolean hasIsLocal()

Rationale:
Adapter property IS_LOCAL is specific to exasol-virtual-schema.

Same applies to com.exasol.adapter.AdapterProperties.ImportProperty

See also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

@ckunki ckunki

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced adapter property IS_LOCAL from virtual-schema-common-java … exasol/exasol-virtual-schema
2 participants
@kaklakariada @ckunki