Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL #268

Closed
ckunki opened this issue Nov 29, 2022 · 0 comments · Fixed by #273
Closed

Remove adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL #268

ckunki opened this issue Nov 29, 2022 · 0 comments · Fixed by #273
Assignees
@kaklakariada @ckunki
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Collaborator

ckunki commented Nov 29, 2022 •
edited

Currently all constants and methods are Implemented in class virtual-schema-common-java/AdapterProperties.

Constant and methods Rationale
Constant BINARY_COLUMN_HANDLING
Checker method: hasBinaryColumnHandling()
Getter method: getBinaryColumnHandling()		 Property is not implemented, yet
Constant IS_LOCAL_PROPERTY
Checker method: public boolean hasIsLocal()
Getter method: public boolean isLocalSource()		 Specific only for VSEXA, and will be moved there see also exasol/exasol-virtual-schema#85
Constant EXCEPTION_HANDLING
Checker method: public boolean x()
Getter method: public boolean x()		 Not in the the scope of the current ticket #268, potentially remove, see also #269

Methods:

  • Checker: Method for checking if property specified
  • Getter: Method for retrieving the property's value
@ckunki ckunki added the refactoring Code improvement without behavior change label Nov 29, 2022
This was referenced Nov 29, 2022
Closed
Closed
@ckunki ckunki self-assigned this Jul 6, 2023
@ckunki ckunki mentioned this issue Jul 6, 2023
Merged
@ckunki ckunki changed the title Remove property BINARY_COLUMN_HANDLING Remove adapter properties Jul 6, 2023
@ckunki ckunki changed the title Remove adapter properties Remove adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL Jul 6, 2023
@ckunki ckunki changed the title Remove adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL Remove adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL Jul 6, 2023
@kaklakariada kaklakariada self-assigned this Jul 6, 2023
@ckunki ckunki mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

@ckunki ckunki

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed adapter properties BINARY_COLUMN_HANDLING and IS_LOCAL exasol/virtual-schema-common-java
2 participants
@kaklakariada @ckunki