This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Fix the Date and Timestamp import issue (#45). #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `3.1.0` version of Apache Hive, the JavaDateObjectInspector[0] returns a Hive Date type instead of Java SQL Date type. This breaks the import since Exasol cannot recognize (emit) Hive date type, it expects a `java.sql.date`. Similar issue with a timestamp type. This commit fixes the issue by converting the Hive date and timestamp values into their corresponding Java SQL counterparts. Additionally, updates the Hadoop version to `3.0.0` and adds tests for type conversions. However, this breaks the backward compatibility, since we can only support Hive version above `3.1.0`. [0]: https://github.com/apache/hive/blob/rel/release-3.1.0/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaDateObjectInspector.java#L39-L42
AnastasiiaSergienko
suggested changes
May 7, 2020
| break; | ||
| case "java.sql.Date": | ||
| obj = Date.valueOf(value); | ||
| obj = java.sql.Date.valueOf(value); | ||
| break; | ||
| case "java.lang.Boolean": | ||
| obj = Boolean.valueOf(value); |
There was a problem hiding this comment.
Maybe you can also add qualified names to other classes of this switch to make it consistent and clearer
hadoop-etl-common/src/main/java/com/exasol/hadoop/HdfsSerDeImportService.java
Show resolved
Hide resolved
hadoop-etl-common/src/test/java/com/exasol/hadoop/RCFileWriter.java
Outdated
Show resolved
Hide resolved
hadoop-etl-common/src/test/java/com/exasol/hadoop/HdfsSerDeImportServiceDateTimeTest.java
Show resolved
Hide resolved
AnastasiiaSergienko
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.