Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare CRAN submission #79

Closed
tomuben opened this issue Aug 27, 2021 · 1 comment
Closed

Prepare CRAN submission #79

tomuben opened this issue Aug 27, 2021 · 1 comment
Assignees
@tomuben
Labels
feature Product feature

Comments

@tomuben
Copy link
Collaborator

tomuben commented Aug 27, 2021

Background

Currently any users of r-exasol need to compile the package on their machines, which require additional dependencies (RTools on Windows for example). It would be much easier for the users of this package to install the binary package from CRAN.
Note: CRAN only provides binary packages for Windows and MacOsX. For Linux, still the compilation will be required.

Acceptance Criteria

r-exasol as binary package on CRAN.
@tomuben tomuben added feature Product feature source:exasol labels Aug 27, 2021
@tomuben tomuben self-assigned this Aug 27, 2021
@tomuben
Copy link
Collaborator Author

tomuben commented Aug 27, 2021 •
edited

Here the points identified to fix until now:

  • Remove assert()/q()
  • Check driver shared libraries => Need to change to download on demand / check how RPostgres handles this
  • Check Copyright Notices
  • Update authors/contacts

Check CRAN
https://cran.r-project.org/web/packages/policies.html

@tomuben tomuben mentioned this issue Sep 29, 2021
Open
tomuben added a commit that referenced this issue Oct 6, 2021
@tomuben @morazow @tkilias
#79 Prepare cran release (#83)
638d537 
1. Removed assert() in connection_controller.cpp
2. Added notice files for external libraries
3. Several fixes in DESCRIPTION
4. Removed preloaded ODBC driver
5. Removed debug prints in http_tests.cpp
6. Added newline at end of common.cpp/common.h
7. Removed GNU extension in makefile and create object file list via sed
8. Added a Dockerfile for running CRAN submission check
9. Renamed Exasol DSN.R to Exasol_DSN.R
10. Removed unused code (dbApply)
11. Increased RoxygenNote v7.1.1 -> v7.1.2
12. Added doc/ and .git/ to .Rbuildignore
13. Moved ax_check_openssl.m4
14. Updated link to exasol page (https://www.exasol.com/portal)
15. Removed None-ASCII characters from Author field in DESCRIPTION
16. Removed link to EXAupper in documentation
17. Added cleanup script
18. Split up EXADBI.R into several files
19. Fixed documentation
20. Changed encoding to UTF-8
21. Added @author and @export on all public API
22. Added changes_7.0.0.md
22. Install ODBC driver in test docker container
23. Changed odbc key "Data_Source_name" to "Data_Source_Name"
24. Added documentation for C layer functions exposed to R.
25. Removed @export of undefined methods: dbUnloadDriver, dbGetException, dbListResults, dbGetStatement & dbGetRowCount
26. Added @export of custom API's and missing DBI API
27. Added dbFetch (as per documentation fetch() is legacy code and modern backends should implement dbFetch)
28. marked dbCurrentSchema() as None-DBI-API
29. Added test for dbReadTable()
30. Added a known problem section to the README.md

Co-authored-by: Muhammet Orazov <m.orazow@gmail.com>
Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
@tomuben tomuben closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomuben tomuben

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomuben