Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbodbc feature can't be used for poetry based project setup #146

Closed
1 task done
Nicoretti opened this issue Jul 4, 2022 · 0 comments · Fixed by #145 or #192
Closed
1 task done

turbodbc feature can't be used for poetry based project setup #146

Nicoretti opened this issue Jul 4, 2022 · 0 comments · Fixed by #145 or #192
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@Nicoretti
Copy link
Member

Nicoretti commented Jul 4, 2022

Description

Due to differences in the structure/naming of build folder(s) and artifacts when using poetry instead of pip, building the turbodbc src package will fail. For further details see blue-yonder/turbodbc#358.

Additional complexity to this problem may be added by the fact that for the turbodbc project it may not be possible or feasible to back port the fix and therefore a version update of the turbodbc dependency may also be needed.

requirements_extras.txt

turbodbc==3.3.0 # 4.0.0 introduced some breaking change (e.g. drops Python 2.7 support) if the fix is not backported

Possible Solution(s)

  • Drop turbodbc feature/support
  • The turbodbc project also provides a wheel for the different target systems (additional to the src distribution)
  • The turbodbc project fixes the deduction of the build- paths/artifacts
    • Update the version of the dependency if the fix isn't back ported
      (Due to the fact that the latest turbodbc package requires python >= 3.8 this implies we also address Remove support for Python < 3.8 #135)

Tasks

@Nicoretti Nicoretti added the bug Unwanted / harmful behavior label Jul 4, 2022
@Nicoretti Nicoretti self-assigned this Jul 4, 2022
@Nicoretti Nicoretti linked a pull request Jul 7, 2022 that will close this issue
@Nicoretti Nicoretti reopened this Jul 14, 2022
Nicoretti added a commit that referenced this issue Aug 11, 2022
fixes #146

The latest version of turbodbc work fine together with poetry,
thefore support got reenabled and depent version got bumped to 4.5.4
Nicoretti added a commit that referenced this issue Aug 12, 2022
fixes #146

The latest version of turbodbc (4.5.4) works together with poetry,
therefore support can be re enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
1 participant