-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement metadata queries with odbc metadata functions for pyodbc to avoid deadlocks #90
Reimplement metadata queries with odbc metadata functions for pyodbc to avoid deadlocks #90
Conversation
I checked the Travis builds and it seems they failed, because the secret environment variables were not available for the pull request. |
@tkilias thank you for your contribution. I will review this PR with @nndo1991 next week. Travis secrets are not readable for outside collaborators, as this would allow leakage of the EXASOL test DB credentials (could be fixed if we figure out how to run EXASOL via GitHub actions #85). |
I had a quick glance at the changes. A review of base.py will take some time as besides the code changes a lot of formatting changes came in. |
@BY-jk Do you mind, if I first try to use docker-db? I tested integration-test-docker-environment with Direct_IO=False and would add a switch to activate this. |
@tkilias switching to GitHub Actions and using EXASOL in a docker image would be a huge step forward. It will remove the dependency on the EXASOL hosted test DB, allow this project to test against a preferred (or even multiple) EXASOL versions, potentially allow for more parallelism in testing (hence reducing build times). |
Will do another pull request for the docker-db stuff, after that we can rebase this one. One interesting thing I found during my testing is, that I could start the docker-db without direct_io=false in Github actions. https://github.com/tkilias/integration-test-docker-environment/runs/688785706 |
All implemented functions have a SQL Fallback in case pyodbc is not used. get_foreign_keys currently has the problem that it seems that at the moment the metadata function SQLForeignKeys does not work.
…ns and sql fallback
first deadlock tests
a492bf7
to
10ff30a
Compare
Situation:
Solution:
I would appreciate your feedback.