Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate expected result datatypes from json #249

Closed
ckunki opened this issue Aug 26, 2022 · 2 comments · Fixed by #250
Closed

Evaluate expected result datatypes from json #249

ckunki opened this issue Aug 26, 2022 · 2 comments · Fixed by #250
Labels
feature Product feature

Comments

@ckunki
Copy link
Collaborator

ckunki commented Aug 26, 2022

Exasol version 8 and higher provide expected data types for result set as additional JSON content.

This enables JDBC-based virtual schema adapters to

  • avoid deriving the result data types from the values
  • save one query

The current ticket therefore requests to evaluate the additional elements from json and transfer them into internal Pojos.

@ckunki ckunki changed the title Evaluate expected result datatypes Evaluate expected result datatypes from json Aug 26, 2022
@ckunki ckunki added the feature Product feature label Aug 26, 2022
@ckunki
Copy link
Collaborator Author

ckunki commented Sep 8, 2022

How should PushDownRequest inform about whether the json actually contained an entry "selectListDataTypes" or not?

  • return null or empty list?
  • return an optional or a list
  • have a separate method boolean hasSelectListDataTypes()

@ckunki
Copy link
Collaborator Author

ckunki commented Sep 8, 2022

Data type DECIMAL has two properties precisionand scale, reflected by method DataType.createDecimal(final int precision, final int scale).
If these properties are missing in JSON to parse PushDownRequest from: should the parser provide default value(s)? E.g. call DataType.createDecimal(-1, -1)?

ckunki added a commit that referenced this issue Sep 8, 2022
enhanced parser, added unit tests
some questions remain, see ticket
ckunki added a commit that referenced this issue Sep 9, 2022
* #249 implemented 
remaining questions: see ticket #249 
Co-authored-by: Christoph Pirkl <christoph.pirkl@exasol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant