Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BaseCamera to Camera #1087

Closed
3 tasks
eonarheim opened this issue Jan 21, 2019 · 0 comments
Closed
3 tasks

Rename BaseCamera to Camera #1087

eonarheim opened this issue Jan 21, 2019 · 0 comments
Assignees
@eonarheim
Labels
api change Breaking api change tech debt Label applied to confusing, poorly named, bug prone, or other less than ideal code
Milestone
0.21.0 Release

Comments

@eonarheim
Copy link
Member

Context

The BaseCamera name is confusing as it implys that the Camera must be extended in order to be used, this is not true.

Proposal

  • Rename BaseCamera to Camera
  • Provide an off-ramp deprecation notice an a dummy BaseCamera
  • Fix any references in code/tests to BaseCamera
@eonarheim eonarheim added api change Breaking api change tech debt Label applied to confusing, poorly named, bug prone, or other less than ideal code labels Jan 21, 2019
@eonarheim eonarheim added this to the 0.21.0 Release milestone Jan 21, 2019
@eonarheim eonarheim self-assigned this Jan 21, 2019
@eonarheim eonarheim mentioned this issue Jan 22, 2019
Merged
4 tasks
eonarheim added a commit that referenced this issue Jan 26, 2019
@eonarheim
[#1087] Change BaseCamera to Camera (#1089)
916a408 
Closes #1087 

## Changes:

- Change BaseCamera to Camera
- Update `@obsolete` to work on classes
@jedeen jedeen changed the title Rename BaseCameara to Camera Rename BaseCamera to Camera Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eonarheim eonarheim

Labels
api change Breaking api change tech debt Label applied to confusing, poorly named, bug prone, or other less than ideal code
Projects
None yet
Milestone
0.21.0 Release
Development

No branches or pull requests
1 participant
@eonarheim