Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation #461

Merged
merged 20 commits into from
Jun 17, 2015
Merged

Fix rotation #461

merged 20 commits into from
Jun 17, 2015

Conversation

jedeen
Copy link
Member

@jedeen jedeen commented Jun 12, 2015

fixes #282

@kamranayub
Copy link
Member

+100 XP

On Fri, Jun 12, 2015, 04:36 Josh Edeen notifications@github.com wrote:

fixes #282 #282

You can view, comment on, or merge this pull request online at:

#461
Commit Summary

  • basic visual test setup
  • created spec test file for Actions
  • addition spec setup
  • RotateTo will now use shortest distance by default
  • added RotationType enum
  • you can now specify a rotation type for RotateTo
  • cleaning up unnecessary block
  • Merge branch 'master' of https://github.com/excaliburjs/Excalibur
    into fix-rotation
  • bringing RotateBy up to feature parity with RotateTo
  • fix direction calc for shortest and longest paths
  • removing ActionSpec
  • clean-up
  • fixed negative distance calculations
  • updated RotateTo tests
  • cleanup csproj
  • update rotateBy() signature
  • fixing RotateBy negative distance
  • updated RotateBy tests
  • Merge branch 'master' of https://github.com/excaliburjs/Excalibur
    into fix-rotation
  • update visual tests index

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#461.

eonarheim added a commit that referenced this pull request Jun 17, 2015
@eonarheim eonarheim merged commit 5ed4e55 into master Jun 17, 2015
@eonarheim eonarheim deleted the fix-rotation branch June 17, 2015 05:39
@jedeen jedeen added this to the 0.5.1 Release milestone May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix RotateTo and RotateBy to turn by the the shortest angle by default
3 participants