Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1044] Fix iOS pointer events, include down + defense #1046

Merged
merged 9 commits into from Oct 13, 2018
Merged

[#1044] Fix iOS pointer events, include down + defense #1046

merged 9 commits into from Oct 13, 2018

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Oct 6, 2018 •
edited

===:clipboard: PR Checklist :clipboard:===

  • 馃搶 issue exists in github for these changes
  • 馃敩 existing tests still pass
  • 馃搻 new tests written and passing / old tests updated with new scenario(s)
  • 馃搫 changelog entry added (or not needed)

==================

Closes #1044

Changes:

  • Update so pointer down counts as a last position
  • Added some defense if lastWorldPos is null

@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Oct 6, 2018
kamranayub
kamranayub requested changes Oct 7, 2018
View reviewed changes
Copy link
Member

@kamranayub kamranayub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should have a test for this, right?

@eonarheim eonarheim merged commit 1303192 into master Oct 13, 2018
@eonarheim eonarheim deleted the bugfix/1044-fix-ios-pointer branch October 13, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamranayub kamranayub kamranayub approved these changes

@jedeen jedeen jedeen approved these changes

Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eonarheim @kamranayub @jedeen