[#1066] Add EventTypes enum to Events #1065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
===:clipboard: PR Checklist :clipboard:===
==================
Closes #1066
Changes:
First time PR Questions:
Not sure how to test this - if there is a place where I can drop in the enum values to make sure it's encluded do let me know.
Additionally - I noticed that there two events mapping to the same string value -
EventType.Enter
as well asEventType.EnterTrigger
- what's the reason for this?Do I need to open an issue for this?
Do I update the changelog?
Tested locally - with this simple scenario and seems good.