fix: Make engine parameter optional for scene constructor #1677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This minor change should address #1363.
As additional information, I noticed there aren't any usages within the codebase which invoke the parameter-less constructor for
Scene
. However, there are usages with theEngine
argument supplied scattered throughout spec and test files. The usages ofnew Scene()
appear to be confined to the documentation.I also noticed there had been a change made in the past (#1068) which caused the
Engine
argument to be mandatory in the constructor signature to begin with. It's not clear to me exactly why that was done given the context available.===:clipboard: PR Checklist :clipboard:===
==================