Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make engine parameter optional for scene constructor #1677

Merged
merged 1 commit into from Oct 4, 2020
Merged

fix: Make engine parameter optional for scene constructor #1677

merged 1 commit into from Oct 4, 2020

Conversation

miqh
Copy link
Contributor

@miqh miqh commented Oct 4, 2020

Hello,

This minor change should address #1363.

As additional information, I noticed there aren't any usages within the codebase which invoke the parameter-less constructor for Scene. However, there are usages with the Engine argument supplied scattered throughout spec and test files. The usages of new Scene() appear to be confined to the documentation.

I also noticed there had been a change made in the past (#1068) which caused the Engine argument to be mandatory in the constructor signature to begin with. It's not clear to me exactly why that was done given the context available.


===:clipboard: PR Checklist :clipboard:===

  • 馃搶 issue exists in github for these changes
  • 馃敩 existing tests still pass
  • 馃檲 code conforms to the style guide
  • 馃搻 new tests written and passing / old tests updated with new scenario(s)
  • 馃搫 changelog entry added (or not needed)

==================

@eonarheim eonarheim added the Hacktoberfest Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/ label Oct 4, 2020
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miqh Thanks for your contribution!

@eonarheim
Copy link
Member

@miqh I think that the change to make it mandatory introduced in #1068 was an oversight on our part.

@eonarheim eonarheim merged commit 03c4faa into excaliburjs:main Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants