New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Graphics Component simplification #2893

Merged

eonarheim merged 2 commits into main from refactor/graphics-component-simplification

Jan 20, 2024

Member

eonarheim commented Jan 19, 2024 •

edited

Loading

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

This PR refactors the GraphicsComponent to be simpler.

Remove confusing Graphics Layering from ex.GraphicsComponent, recommend we use the ex.GraphicsGroup to manage this behavior
Update ex.GraphicsGroup to be consistent and use offset instead of pos for graphics relative positioning


          refactor: Graphics Component simplification

4e081bf

eonarheim added the api change label


          add show back as a deprecated alias

c6baf82

eonarheim merged commit ff73735 into main

5 checks passed

eonarheim deleted the refactor/graphics-component-simplification branch

January 20, 2024 03:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment