Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2933] Children inherit their coordinate plane #2936

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Feb 17, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2933

This PR forces children to inherit their parent's coordinate plane, it will always be the coordinate plane of the top most parent.

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Feb 17, 2024
Copy link

cloudflare-pages bot commented Feb 17, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb5c77f
Status: ✅  Deploy successful!
Preview URL: https://34db93c3.excaliburjs.pages.dev
Branch Preview URL: https://fix-2933-children-inherit-co.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 828558a into main Feb 17, 2024
3 of 5 checks passed
@eonarheim eonarheim deleted the fix/2933-children-inherit-coordplan branch February 17, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child entity should inherit transform.coordPlane of parent
1 participant