Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Firefox + Linux custom shader issue with glsl compiler attribute optimization #2943

Merged
merged 1 commit into from Feb 29, 2024

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR fixes an issue where Firefox on Linux would throw an error when using custom Materials due to unused attributes caused by glsl compiler optimization.

Before it would throw and crash excalibur

image

Now after, it will log a warning because this is potentially a bug, or at minimum something you should look at

image

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Feb 29, 2024
@eonarheim eonarheim merged commit f913222 into main Feb 29, 2024
6 of 7 checks passed
@eonarheim eonarheim deleted the fix/linux-ff-webgl-attribute-optimization-bug branch February 29, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant