-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for exporting the images in dark mode (with black background) #4689
Comments
Oh totally missed it, btw can we somewhat increase the size of the logo as it seems small relatively? |
Yep we definitely need to improve the visibility of the theme icon - this is part of the export redesign as well. And we should probably export in same theme which is set by user, IOW if its dark theme -> export in dark theme as well |
Appreciate your quick response over this :), yeah it can be exported in the same mode by default and maybe there can be a manual setting too (as it's for now) |
This was actually discussed at length before and the team got divided on how this should work. I myself am for not aligning it to the UI theme, though I acknowledge the potential UX issues (the problem is, neither approach is free of UX issues). |
Whats the reason for not aligning with the UX theme ? From my understanding its more likely that user will want to export the data in same theme in which they are drawing. We can take a look at the data probably before taking the call. |
Currently, when a user tries to export the work it only supports exporting in light theme only instead if the user opts for exporting in dark mode (that is with black background) then it should be exported in the desired manner.
Some images are attached for more ref:
Here is the screenshot of the actual image
![excali1](https://user-images.githubusercontent.com/52465652/152098669-64f300bf-3abe-4183-9d40-1ee15fd52dd7.png)
Here is the screenshot of the exported image
![excali2](https://user-images.githubusercontent.com/52465652/152098675-8ed3357f-8742-4cad-8815-b00b546cebf5.png)
P.S: Great application team GG 😄
The text was updated successfully, but these errors were encountered: