feat: Sync Export Theme to Current Theme #7959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
MxMossy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change syncs the dark toggle to the current theme when a user opens the export dialogue.
I've read the arguments against this in #2026 but wanted to throw in my 2 cents.
I often use excalidraw for small edits and mockups and remember being confused why it was exporting in light mode despite my work being in dark mode. Of course, after a quick google I realized there was a toggle for it.
#4689 is another example of a user getting confused (granted with the old ui). As @ad1992 noted in the discussion, it's more likely a user wants to export what they are seeing. Generally, I would think if a user is working on a longer project that involves switching themes during the day, they are more likely to be a power user who is aware of this quirk.
As a final note, I use dark mode to avoid getting flash-banged by bright regions so the temporary light theme preview is an annoyance, as nit-picky as that sounds.
Open to discussion on this though!