Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove the word toggle from labels #2648

Merged
merged 4 commits into from Dec 21, 2020
Merged

refactor: Remove the word toggle from labels #2648

merged 4 commits into from Dec 21, 2020

Conversation

lipis
Copy link
Member

@lipis lipis commented Dec 21, 2020

Continuation of #2645

@vercel
Copy link

vercel bot commented Dec 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/62e066z0n
✅ Preview: https://excalidraw-git-toggle.excalidraw.now.sh

@dwelle
Copy link
Member

dwelle commented Dec 21, 2020

Why the variable naming change? It's still toggling. Now we'll have variables named zenMode which would indicate a boolean or something, and it's a function.

@lipis
Copy link
Member Author

lipis commented Dec 21, 2020

Yeah the variable names might have to stay untouched.. I was just doing that.

* 'master' of github.com:excalidraw/excalidraw:
  chore(deps): bump browser-nativefs from 0.11.2 to 0.12.0 (#2634)
@dwelle
Copy link
Member

dwelle commented Dec 21, 2020

Looking good.

@dwelle dwelle merged commit b0eeb8e into master Dec 21, 2020
@dwelle dwelle deleted the toggle branch December 21, 2020 13:58
lipis added a commit that referenced this pull request Dec 21, 2020
…aster

* 'master' of github.com:excalidraw/excalidraw:
  refactor: Remove the word toggle from labels (#2648)
  chore(deps): bump browser-nativefs from 0.11.2 to 0.12.0 (#2634)
  feat: Checkmark to toggle context-menu-items (#2645)
  align items in context menu (#2640)
  fix: Center zoom on iPhone and iPad (#2642)
  fix: Don't break zoom when zooming in on UI (#2638)
  chore: Remove changelog check and graphql (#2639)
  improvement: Tweak error message on image import (#2619)
  chore(deps-dev): bump webpack in /src/packages/excalidraw (#2625)
  docs: excalidraw package usage example tweaks (#2608)
  feat: Add onExportToBackend prop so host can handle it (#2612)
  fix: Consistent case for export locale strings (#2622)
  improvement: Support numbers with commas in them (#2636)
  chore(deps-dev): bump @babel/preset-env in /src/packages/excalidraw (#2624)
  chore(deps-dev): bump webpack-bundle-analyzer (#2623)
  fix(appstate.ts): Remove unnecessary console.error as it was polluting Sentry (#2637)
  chore(deps-dev): bump webpack-bundle-analyzer in /src/packages/utils (#2626)
  chore(deps-dev): bump webpack in /src/packages/utils (#2627)
  chore(deps-dev): bump @babel/preset-env in /src/packages/utils (#2628)
  chore(deps-dev): bump eslint-config-prettier from 7.0.0 to 7.1.0 (#2632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants