Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak editing behavior #2668

Merged
merged 2 commits into from Dec 25, 2020
Merged

feat: tweak editing behavior #2668

merged 2 commits into from Dec 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 25, 2020

For now, if we are editing a group and then click(pointing down) elsewhere, it would simply exit the group editing state and nothing else would happen. The expected behavior is that if we are editing a group and then click on an element outside the group, we would end up not only exiting editing the group but also with that element selected.

If you feel that current editing behavior is more appropriate, feel free to close this PR.

@vercel
Copy link

vercel bot commented Dec 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/29dfw5sa0
✅ Preview: https://excalidraw-git-fork-vimniky-tweak-editing-behavior.excalidraw.now.sh

@lipis
Copy link
Member

lipis commented Dec 25, 2020

Yes!

@lipis
Copy link
Member

lipis commented Dec 25, 2020

We need to fix the tests though :)

@dwelle
Copy link
Member

dwelle commented Dec 25, 2020

I'll fix the tests coz I wanted to clear one thing up.

@dwelle
Copy link
Member

dwelle commented Dec 25, 2020

@vimniky thanks for the fix, this is indeed the correct behavior — well, "more correct" behavior: ultimately we'll want to not exit just the subgroup we're editing, if we click on a parent group. But that's for another time.

@dwelle dwelle merged commit bc414cc into excalidraw:master Dec 25, 2020
lipis added a commit that referenced this pull request Dec 26, 2020
…charts

* 'master' of github.com:excalidraw/excalidraw:
  feat: tweak editing behavior (#2668)
  chore: update Sentry (#2669)
  chore: New Crowdin updates (#2620)
  chore: Remove unused cursorX, cursorY from AppState (#2665)
lipis added a commit that referenced this pull request Dec 26, 2020
…ne-chart

* 'master' of github.com:excalidraw/excalidraw:
  feat: tweak editing behavior (#2668)
  chore: update Sentry (#2669)
  chore: New Crowdin updates (#2620)
  chore: Remove unused cursorX, cursorY from AppState (#2665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants