Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scene not initialized properly when tab not focused #2677

Merged
merged 5 commits into from Dec 29, 2020

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Dec 27, 2020

  • fixes a regression introduced during rewrite for npm package: by moving to promise-based initialization, we've been mistakenly been early-resolving in late-initialization scenarios which ended up not initializing the scene properly
  • also fixed an issue where late initialization wasn't prompting due to onChange callback being called early and overriding localStorage with empty data

@vercel
Copy link

vercel bot commented Dec 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/buep6c1v6
✅ Preview: https://excalidraw-git-fixhiddenjsoninit.excalidraw.vercel.app

src/components/App.tsx Outdated Show resolved Hide resolved
src/components/App.tsx Outdated Show resolved Hide resolved
src/components/App.tsx Outdated Show resolved Hide resolved
dwelle and others added 2 commits December 29, 2020 20:48
Co-authored-by: Lipis <lipiridis@gmail.com>
Co-authored-by: Lipis <lipiridis@gmail.com>
Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwelle dwelle merged commit aef3644 into master Dec 29, 2020
@dwelle dwelle deleted the fix_hidden_json_init branch December 29, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants